-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Added data-test attributes for testing #11254
Conversation
I'd merge quickly if checks passed as this is likely to conflict with everything. Wondering why you didn't approach this with a set of smaller PRs to start with. |
Is this a re-work of #11254? Just trying to figure out if this needs to be thoroughly reviewed again, or if it's the same stuff, split out. I'd still honestly rather just finish up the prior one, if it's all the same. Not sure if you or others have feelings on this. |
efcd38e
to
df31735
Compare
Codecov Report
@@ Coverage Diff @@
## master #11254 +/- ##
==========================================
- Coverage 65.61% 61.49% -4.13%
==========================================
Files 834 834
Lines 39559 39556 -3
Branches 3610 3610
==========================================
- Hits 25957 24325 -1632
- Misses 13494 15050 +1556
- Partials 108 181 +73
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
f0c0528
to
60f2d1b
Compare
60f2d1b
to
89024ae
Compare
I fixed review findings and splitted change related to attribute from #11134 into this PR and next I will submit test code using these attributes. It will be easier now when this will be merged - smaller changes then I think. Please for green light for this and merging to avoid conflicts - real blocker for me in pushing forward. |
Aside from the aforementioned tweaks/questions/suggestions, this LGTM. Let's tie up those loose ends and merge this thing! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'll merge this if/when the light turns green :D |
ace3e48
to
26b6e50
Compare
* Added data-test attributes for testing * fixed incorrect naming change * review changes
SUMMARY
Added test attribute for cypress testing.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION