Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added data-test attributes for testing #11254

Merged
merged 3 commits into from
Oct 14, 2020

Conversation

adam-stasiak
Copy link
Contributor

SUMMARY

Added test attribute for cypress testing.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@mistercrunch
Copy link
Member

I'd merge quickly if checks passed as this is likely to conflict with everything. Wondering why you didn't approach this with a set of smaller PRs to start with.

@rusackas
Copy link
Member

Is this a re-work of #11254? Just trying to figure out if this needs to be thoroughly reviewed again, or if it's the same stuff, split out. I'd still honestly rather just finish up the prior one, if it's all the same. Not sure if you or others have feelings on this.

@codecov-io
Copy link

codecov-io commented Oct 14, 2020

Codecov Report

Merging #11254 into master will decrease coverage by 4.12%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11254      +/-   ##
==========================================
- Coverage   65.61%   61.49%   -4.13%     
==========================================
  Files         834      834              
  Lines       39559    39556       -3     
  Branches     3610     3610              
==========================================
- Hits        25957    24325    -1632     
- Misses      13494    15050    +1556     
- Partials      108      181      +73     
Flag Coverage Δ
#cypress ?
#javascript 62.71% <66.66%> (+0.01%) ⬆️
#python 60.77% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/chart/Chart.jsx 10.90% <0.00%> (-47.28%) ⬇️
superset-frontend/src/components/DeleteModal.tsx 100.00% <ø> (ø)
superset-frontend/src/components/EditableTitle.tsx 74.28% <ø> (-15.72%) ⬇️
superset-frontend/src/components/FaveStar.tsx 82.35% <ø> (-17.65%) ⬇️
...rset-frontend/src/components/ListView/ListView.tsx 95.65% <ø> (-3.27%) ⬇️
...set-frontend/src/components/ListViewCard/index.tsx 93.61% <ø> (-6.39%) ⬇️
superset-frontend/src/components/Modal.tsx 94.11% <ø> (ø)
...uperset-frontend/src/components/PopoverSection.jsx 100.00% <ø> (ø)
...end/src/components/Select/SupersetStyledSelect.tsx 73.33% <ø> (-17.78%) ⬇️
...set-frontend/src/components/URLShortLinkButton.jsx 88.23% <ø> (-11.77%) ⬇️
... and 214 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc74b5d...26b6e50. Read the comment docs.

@adam-stasiak
Copy link
Contributor Author

Is this a re-work of #11254? Just trying to figure out if this needs to be thoroughly reviewed again, or if it's the same stuff, split out. I'd still honestly rather just finish up the prior one, if it's all the same. Not sure if you or others have feelings on this.

I fixed review findings and splitted change related to attribute from #11134 into this PR and next I will submit test code using these attributes. It will be easier now when this will be merged - smaller changes then I think. Please for green light for this and merging to avoid conflicts - real blocker for me in pushing forward.

@rusackas
Copy link
Member

Aside from the aforementioned tweaks/questions/suggestions, this LGTM. Let's tie up those loose ends and merge this thing! 🚀

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas
Copy link
Member

I'll merge this if/when the light turns green :D

@rusackas rusackas merged commit fc03549 into apache:master Oct 14, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
* Added data-test attributes for testing

* fixed incorrect naming change

* review changes
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants