Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "fix: keep placeholder in multivalue select when a value exists" #11270

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Oct 14, 2020

Reverts #11181 to fix the issue reported here: #11181 (comment)

I'll wait until EOD before merging in case @eschutho can get a fix in.

to: @ktmud @eschutho @nytai

@codecov-io
Copy link

codecov-io commented Oct 14, 2020

Codecov Report

Merging #11270 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11270      +/-   ##
==========================================
- Coverage   65.57%   65.56%   -0.02%     
==========================================
  Files         831      831              
  Lines       39523    39516       -7     
  Branches     3598     3593       -5     
==========================================
- Hits        25917    25907      -10     
- Misses      13497    13500       +3     
  Partials      109      109              
Flag Coverage Δ
#cypress 55.89% <100.00%> (-0.08%) ⬇️
#javascript 62.62% <100.00%> (-0.05%) ⬇️
#python 60.77% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...explore/components/controls/AdhocFilterControl.jsx 77.66% <ø> (ø)
...src/explore/components/controls/MetricsControl.jsx 89.69% <ø> (-0.19%) ⬇️
superset-frontend/src/components/Select/styles.tsx 98.14% <100.00%> (-0.13%) ⬇️
...ontend/src/dashboard/components/dnd/handleHover.js 75.00% <0.00%> (-25.00%) ⬇️
...ntend/src/dashboard/components/PropertiesModal.jsx 56.32% <0.00%> (-3.45%) ⬇️
...set-frontend/src/dashboard/util/getDropPosition.js 88.88% <0.00%> (-1.59%) ⬇️
superset/db_engine_specs/presto.py 82.07% <0.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb2e6cf...5d4e7c0. Read the comment docs.

@etr2460
Copy link
Member Author

etr2460 commented Oct 14, 2020

Merging after getting a response from Elizabeth. Thanks for the quick reviews!

@etr2460 etr2460 merged commit fc74b5d into master Oct 14, 2020
@ktmud ktmud deleted the revert-11181-elizabeth/multiple-filter-options branch October 20, 2020 06:12
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants