fix(chart-api): cached-indicator always shows value is cached #11326
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently the chart data endpoint always shows data as being cached. This differs from how the legacy endpoint works, which for the first or forced load doesn't show the
cached
pill. This changes the behaviour on the new endpoint to work similar to how the old one works.Expected behaviour (legacy endpoint)
In this video we can see how the
CACHED
pill is deactivated when the data is force refreshed:Current behaviour (v1 chart data endpoint)
Here we see the new data endpoint before the change. Note how the
CACHED
pill is always active:New behaviour (v1 chart data endpoint)
Here we see the new data endpoint after the change:
TEST PLAN
ADDITIONAL INFORMATION