Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart-api): cached-indicator always shows value is cached #11326

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

villebro
Copy link
Member

SUMMARY

Currently the chart data endpoint always shows data as being cached. This differs from how the legacy endpoint works, which for the first or forced load doesn't show the cached pill. This changes the behaviour on the new endpoint to work similar to how the old one works.

Expected behaviour (legacy endpoint)

In this video we can see how the CACHED pill is deactivated when the data is force refreshed:
line-current

Current behaviour (v1 chart data endpoint)

Here we see the new data endpoint before the change. Note how the CACHED pill is always active:
echarts-before

New behaviour (v1 chart data endpoint)

Here we see the new data endpoint after the change:
echarts-after

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
dpgaspar Daniel Vaz Gaspar
@codecov-io
Copy link

codecov-io commented Oct 19, 2020

Codecov Report

Merging #11326 into master will decrease coverage by 6.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11326      +/-   ##
==========================================
- Coverage   65.66%   59.14%   -6.53%     
==========================================
  Files         835      799      -36     
  Lines       39656    38369    -1287     
  Branches     3604     3401     -203     
==========================================
- Hits        26042    22694    -3348     
- Misses      13505    15494    +1989     
- Partials      109      181      +72     
Flag Coverage Δ
#cypress 56.02% <ø> (+0.25%) ⬆️
#javascript ?
#python 60.82% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/common/query_context.py 87.34% <ø> (ø)
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...rc/dashboard/util/getLayoutComponentFromChartId.js 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx 3.57% <0.00%> (-93.73%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...uperset-frontend/src/utils/getClientErrorObject.ts 0.00% <0.00%> (-89.19%) ⬇️
.../src/dashboard/components/FilterIndicatorGroup.jsx 11.76% <0.00%> (-88.24%) ⬇️
...c/explore/components/controls/withVerification.jsx 9.09% <0.00%> (-87.88%) ⬇️
... and 266 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 735123d...9d612b1. Read the comment docs.

@villebro villebro merged commit 917d02e into apache:master Oct 19, 2020
@villebro villebro deleted the villebro/fix-cache-indicator branch October 19, 2020 13:46
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020

Verified

This commit was signed with the committer’s verified signature. The key has expired.
dpgaspar Daniel Vaz Gaspar
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants