-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bring back type ignore for config import #11333
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11333 +/- ##
==========================================
+ Coverage 65.66% 65.71% +0.04%
==========================================
Files 835 835
Lines 39656 39656
Branches 3604 3604
==========================================
+ Hits 26042 26061 +19
+ Misses 13505 13486 -19
Partials 109 109
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Going to merge this to get green checkmarks back on PRs (we need to sort out these linting mismatches on mypy/black) |
Thanks for fixing this. I've had some issues with tox/mypy/pyenv lately where I think mypy/tox were using the wrong version of python in some cases. This helped https://pypi.org/project/tox-pyenv/, unclear on |
Quickfix
Without #type ignore there is CI problem in pre-commit:
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION