-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add statsd metrics to FAB rest API post, put and delete #11362
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11362 +/- ##
==========================================
- Coverage 65.78% 61.58% -4.20%
==========================================
Files 838 838
Lines 39841 39847 +6
Branches 3655 3655
==========================================
- Hits 26208 24540 -1668
- Misses 13532 15126 +1594
- Partials 101 181 +80
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
Change at the
BaseSupersetModelRestApi
that enables metrics for FAB's post, put and delete REST API endpointsAlso couldn't help myself in doing a small refactor on datasets test to change
self.assert<Cond>
toassert
since we prefer these nowADDITIONAL INFORMATION