Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add statsd metrics to FAB rest API post, put and delete #11362

Merged
merged 8 commits into from
Oct 22, 2020

Conversation

dpgaspar
Copy link
Member

SUMMARY

Change at the BaseSupersetModelRestApi that enables metrics for FAB's post, put and delete REST API endpoints

Also couldn't help myself in doing a small refactor on datasets test to change self.assert<Cond> to assert since we prefer these now

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Oct 21, 2020

Codecov Report

Merging #11362 into master will decrease coverage by 4.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11362      +/-   ##
==========================================
- Coverage   65.78%   61.58%   -4.20%     
==========================================
  Files         838      838              
  Lines       39841    39847       +6     
  Branches     3655     3655              
==========================================
- Hits        26208    24540    -1668     
- Misses      13532    15126    +1594     
- Partials      101      181      +80     
Flag Coverage Δ
#cypress ?
#javascript 62.63% <ø> (-0.01%) ⬇️
#python 60.95% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/base_api.py 98.02% <100.00%> (+0.12%) ⬆️
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupFormatters.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
... and 172 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cae54ac...5daaa49. Read the comment docs.

@dpgaspar dpgaspar changed the title feat: add statsd metrics to FAB rest API post, put and delete [WiP] feat: add statsd metrics to FAB rest API post, put and delete Oct 21, 2020
@dpgaspar dpgaspar changed the title [WiP] feat: add statsd metrics to FAB rest API post, put and delete feat: add statsd metrics to FAB rest API post, put and delete Oct 21, 2020
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpgaspar dpgaspar merged commit b86f779 into apache:master Oct 22, 2020
@dpgaspar dpgaspar deleted the feat/statsd-rest-api-mut branch October 22, 2020 07:56
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants