style: removing outlines on a few key elements #11372
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
React-bootstrap adds styles with a VERY broad
:focus
style, adding goofy outlines all over the place.I'm removing that outline for a few key elements, namely
div
span
andi
so we don't see them in strange places. This should not affect focus on form elements and such, so it has a relatively low impact on accessibility. That said, I admit there may be areas where there's tab-based navigation we DO want to support. In such cases, we should make sure that it's supported (and styled) properly in those relevant components, when we get to do a broader accessibility sweep to meet WCAG standards.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
ADDITIONAL INFORMATION