Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: removing outlines on a few key elements #11372

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Oct 21, 2020

SUMMARY

React-bootstrap adds styles with a VERY broad :focus style, adding goofy outlines all over the place.

I'm removing that outline for a few key elements, namely div span and i so we don't see them in strange places. This should not affect focus on form elements and such, so it has a relatively low impact on accessibility. That said, I admit there may be areas where there's tab-based navigation we DO want to support. In such cases, we should make sure that it's supported (and styled) properly in those relevant components, when we get to do a broader accessibility sweep to meet WCAG standards.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
outline-before

check-before

After:
outline-after

after

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas changed the title removing outlines on a few key elements style: removing outlines on a few key elements Oct 21, 2020
@codecov-io
Copy link

codecov-io commented Oct 21, 2020

Codecov Report

Merging #11372 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11372   +/-   ##
=======================================
  Coverage   61.57%   61.57%           
=======================================
  Files         838      838           
  Lines       39839    39839           
  Branches     3655     3655           
=======================================
  Hits        24532    24532           
  Misses      15126    15126           
  Partials      181      181           
Flag Coverage Δ
#javascript 62.63% <ø> (ø)
#python 60.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f14cf9d...12cd1f8. Read the comment docs.

@rusackas
Copy link
Member Author

@junlincc FYI.

@rusackas rusackas mentioned this pull request Oct 21, 2020
5 tasks
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These funky outlines must GO!

@mistercrunch mistercrunch added the #bug:cosmetic Cosmetic/layout/design tweak needed label Oct 22, 2020
@rusackas rusackas merged commit 6c5da18 into apache:master Oct 22, 2020
@rusackas rusackas deleted the fewer-blue-outlines branch October 22, 2020 05:03
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels #bug:cosmetic Cosmetic/layout/design tweak needed size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants