-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace react-bootstrap Modals with Antd in Datasource #11390
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11390 +/- ##
==========================================
- Coverage 66.59% 56.86% -9.73%
==========================================
Files 863 407 -456
Lines 40986 13647 -27339
Branches 3694 3476 -218
==========================================
- Hits 27295 7761 -19534
+ Misses 13594 5724 -7870
- Partials 97 162 +65
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
superset-frontend/cypress-base/cypress/integration/dashboard_list/card_view.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One main nit to address about skipped tests, and a couple other questions, but generally looking good!
@rusackas I did a rebase and I was forced to add data-test to Modal that won't be removed by the babel plugin - Antd Modals don't accept data-test prop normally, I had to pass it through wrapProps. However I don't think it's a major problem as the modals are lazy rendered, so that data-test would show up in HTML only after a user opens a modal. I also changed a data-test name from |
…che#11390) * ChangeDatasourceModal * DatasourceModal * DeleteModal, AddDatasetModal * Fix tests * Remove unused file * Fix e2e tests * Fix test * Remove it.only * Fix after rebase * Fix e2e tests * Fix data-test in modal * Lint fix
SUMMARY
Replaces usages of react-bootstrap Modals with Antd in
datasource/
.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
The Modals look almost the same as before. The difference is the colour of the Title bar and that the new modals are placed a bit lower. Example below.
Before:
After:
TEST PLAN
ADDITIONAL INFORMATION