Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: datasource editor doesn't save schema #11396

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

lilykuang
Copy link
Member

SUMMARY

  • fix issue with datasource edit doesn't save schema on chart explore

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

https://www.loom.com/share/46b790bdb5cc4128893b8373f6f9eaf2

TEST PLAN

ADDITIONAL INFORMATION

@lilykuang lilykuang changed the title fix: datasource editor doesn't schema fix: datasource editor doesn't save schema Oct 22, 2020
@codecov-io
Copy link

codecov-io commented Oct 22, 2020

Codecov Report

Merging #11396 into master will decrease coverage by 4.19%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11396      +/-   ##
==========================================
- Coverage   65.79%   61.59%   -4.20%     
==========================================
  Files         838      838              
  Lines       39903    39901       -2     
  Branches     3662     3663       +1     
==========================================
- Hits        26253    24579    -1674     
- Misses      13549    15141    +1592     
- Partials      101      181      +80     
Flag Coverage Δ
#cypress ?
#javascript 62.67% <33.33%> (-0.01%) ⬇️
#python 60.95% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-frontend/src/datasource/DatasourceModal.tsx 72.54% <33.33%> (-23.46%) ⬇️
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupFormatters.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
... and 169 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a3d23d...61abeca. Read the comment docs.

@junlincc junlincc requested a review from nytai October 23, 2020 03:27
@mistercrunch mistercrunch merged commit 93d9bd9 into apache:master Oct 23, 2020
@mistercrunch mistercrunch deleted the dataset-editor-schema branch October 23, 2020 04:59
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants