feat: add endpoint to export saved queries using new format #11447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
changed the title
|
A rebase should fix the broken E2E test (see #11453) |
Codecov Report
@@ Coverage Diff @@
## master #11447 +/- ##
==========================================
- Coverage 66.65% 62.37% -4.28%
==========================================
Files 863 864 +1
Lines 41048 41114 +66
Branches 3693 3693
==========================================
- Hits 27359 25644 -1715
- Misses 13592 15291 +1699
- Partials 97 179 +82
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dpgaspar
approved these changes
Oct 30, 2020
| from superset.queries.saved_queries.filters import ( | ||
| SavedQueryAllTextFilter, | ||
| SavedQueryFavoriteFilter, | ||
| SavedQueryFilter, | ||
| ) | ||
| from superset.queries.saved_queries.schemas import ( | ||
| get_delete_ids_schema, | ||
| get_export_ids_schema, |
There was a problem hiding this comment.
not related with this PR, sort of a note to self, this is asking to be DRY'ed
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
…1447) * Add UUID to saved_query * Reuse function from previous migration * Point to new head * feat: add backend to export saved queries using new format
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In line with #11167, this PR adds a new endpoint to export saved queries in the zipped YAML format. This will allow users to easily migrate saved queries between Superset instances.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
Added unit tests for the API and for the new
ExportSavedQueriesCommand.ADDITIONAL INFORMATION