-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datasets): add custom filter for virtual datasets based on sql attribute #11452
Conversation
a0b6d9b
to
f3441f4
Compare
retriggering CI |
Codecov Report
@@ Coverage Diff @@
## master #11452 +/- ##
==========================================
- Coverage 62.26% 61.01% -1.25%
==========================================
Files 863 418 -445
Lines 40978 26067 -14911
Branches 3693 0 -3693
==========================================
- Hits 25516 15906 -9610
+ Misses 15283 10161 -5122
+ Partials 179 0 -179
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but you need to black it
SUMMARY
See linked issue and title
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
ADDITIONAL INFORMATION