Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasets): add custom filter for virtual datasets based on sql attribute #11452

Merged
merged 3 commits into from
Oct 29, 2020

Conversation

nytai
Copy link
Member

@nytai nytai commented Oct 28, 2020

SUMMARY

See linked issue and title

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

  • manually tested dataset "Type" filter
  • unit tested

ADDITIONAL INFORMATION

Sorry, something went wrong.

@nytai nytai marked this pull request as ready for review October 28, 2020 19:08
@nytai nytai requested review from dpgaspar and etr2460 October 28, 2020 19:08
nytai added 2 commits October 28, 2020 12:12

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@nytai nytai force-pushed the tai/fix-virtual-dataset-attr branch from a0b6d9b to f3441f4 Compare October 28, 2020 19:13
@nytai
Copy link
Member Author

nytai commented Oct 28, 2020

retriggering CI

@nytai nytai closed this Oct 28, 2020
@nytai nytai reopened this Oct 28, 2020
@codecov-io
Copy link

codecov-io commented Oct 28, 2020

Codecov Report

Merging #11452 into master will decrease coverage by 1.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11452      +/-   ##
==========================================
- Coverage   62.26%   61.01%   -1.25%     
==========================================
  Files         863      418     -445     
  Lines       40978    26067   -14911     
  Branches     3693        0    -3693     
==========================================
- Hits        25516    15906    -9610     
+ Misses      15283    10161    -5122     
+ Partials      179        0     -179     
Flag Coverage Δ
#javascript ?
#python 61.01% <100.00%> (-0.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/datasets/api.py 92.81% <100.00%> (+0.08%) ⬆️
superset/datasets/filters.py 100.00% <100.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/databases/commands/create.py 31.91% <0.00%> (-59.58%) ⬇️
superset/db_engine_specs/hive.py 53.90% <0.00%> (-30.08%) ⬇️
superset/views/database/mixins.py 59.64% <0.00%> (-22.81%) ⬇️
superset/db_engine_specs/presto.py 69.76% <0.00%> (-12.53%) ⬇️
superset/db_engine_specs/mysql.py 79.59% <0.00%> (-12.25%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/databases/api.py 83.49% <0.00%> (-7.08%) ⬇️
... and 474 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d547c...af89ffe. Read the comment docs.

Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you need to black it

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@nytai nytai merged commit f918ca1 into apache:master Oct 29, 2020
@nytai nytai deleted the tai/fix-virtual-dataset-attr branch October 29, 2020 20:11
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…tribute (apache#11452)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type filter in Dataset CRUD view doesn't work
4 participants