fix: disabled caret change from left to right #11459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11459 +/- ##
==========================================
- Coverage 66.59% 62.26% -4.33%
==========================================
Files 863 863
Lines 40986 40978 -8
Branches 3694 3693 -1
==========================================
- Hits 27295 25516 -1779
- Misses 13594 15283 +1689
- Partials 97 179 +82
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
thank you! |
|
This works, but I thought the conversation was about fully removing the caret to align with our other label+popovers pattern. |
|
Sortby, Metrics and Filters popovers all have caret. We will likely to remove them
to get closer to SIP 34. will address them while we work on reorganizing
the control panel.
…On Wed, Oct 28, 2020 at 10:15 PM Maxime Beauchemin ***@***.***> wrote:
This works, but I thought the conversation was about fully removing the
caret to align with our other label+popovers pattern.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#11459 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQFR5U3IF6GJHTFSAF4HZFLSND255ANCNFSM4TCSW5YA>
.
|
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When clicking on monitor or filter value, caret was changing from left to right while popup was showing up. Right now a caret has only right direction.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
&
After:
&
TEST PLAN
Percentage MetricsandSort Byoptions and click on them to see popupADDITIONAL INFORMATION
Fixes #11434