fix: dashboard tab only shows move cursor when editing

[rusackas]

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before (display mode, wrong cursor):

After (display)

After (edit mode)

TEST PLAN

ADDITIONAL INFORMATION

• Has associated issue: Fixes [dashboard tab] cursor shape #11471
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[codecov-io]

Codecov Report

Merging #11480 into master will decrease coverage by 4.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11480      +/-   ##
==========================================
- Coverage   66.60%   62.25%   -4.36%     
==========================================
  Files         862      862              
  Lines       41212    41208       -4     
  Branches     3716     3716              
==========================================
- Hits        27451    25654    -1797     
- Misses      13660    15376    +1716     
- Partials      101      178      +77     

Flag	Coverage Δ
#cypress	?
#javascript	62.69% <ø> (ø)
#python	61.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/SqlLab/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/dashboard/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/index.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/dashboard/index.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/setup/setupColors.js	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/chart/ChartContainer.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/setup/setupFormatters.js	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/reducers/index.js	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/setup/setupPluginsExtra.js	0.00% <0.00%> (-100.00%)	⬇️
... and 172 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e024267...93df56f. Read the comment docs.

[ktmud]

Why was this not a problem before? Was dragdroppable-tab dynamically added but somehow it's not possible to do so in the new implementation?

[rusackas]

Well, it's all a big pile of overrides!

The prior situation was "cursor:move" all the way down to the tab text, which was an <input type="button"> which had an override with cursor:pointer via this super simple selector:
.dashboard-component-tabs .nav-tabs>li .editable-title input[type=button]

Instead of a button, that tab text is now in a span, so the override is not being applied. It happened here via #10936

[graceguo-supercat]

thank you!