-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace react-bootstrap MenuItems with Antd Menu #11487
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11487 +/- ##
==========================================
- Coverage 66.58% 62.29% -4.29%
==========================================
Files 873 873
Lines 41767 41885 +118
Branches 3827 3856 +29
==========================================
- Hits 27809 26094 -1715
- Misses 13856 15611 +1755
- Partials 102 180 +78
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Just a note that #11491 may affect this, or vice versa. |
4859c3f
to
0b37f91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One remaining nit here about the 30px value we discussed on another PR, but in general this LGTM. Approving, but not yet merging in case you'd like to tackle that tweak here, or rebase if the other PR comes in first.
d1513fc
to
c56a925
Compare
SUMMARY
This PR is first of the series - the goal is to get rid of all react-bootstrap's MenuItem usages. In this PR I refactored CopyToClipboard, LanguagePicker, HeaderActionsDropdown and DateFilterControl. In the case of DateFilterControl, I also fixed styling bug (as on the screenshot below) and replaced Input component for UI consistency.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
DateFilterControl - before:
DateFilterControl - after:
HeaderActionsDropdown - before:
HeaderActionsDropdown - after:
TEST PLAN
ADDITIONAL INFORMATION