-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make logo link point to welcome page #11519
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11519 +/- ##
==========================================
+ Coverage 66.57% 66.63% +0.05%
==========================================
Files 873 873
Lines 41777 41767 -10
Branches 3826 3826
==========================================
+ Hits 27814 27832 +18
+ Misses 13861 13833 -28
Partials 102 102
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Additionally, should we also make the home page route |
@nytai I think the reason is that it's a bit of a puzzle around how FAB does things and issues around python circular imports. I don't think it's super hard put requires a bit of thinking / refactoring. |
Adjusting the route was on our radar for follow-up, when the moon is right. I'd actually wondered if it could just be at The other quandry is if/when we want to add profile/role information to the homepage (perhaps as a sidebar, perhaps as a hero/header) to replace the feature of the user page you could previously get to by clicking the logo. ... or maybe that should all be shoved under the user/account menu in the top right somehow. ¯\_(ツ)_/¯ |
Should we plan adding user profile picture as well? Maybe use gravatar.com to get started? |
SUMMARY
New that we have a home page, let's point the logo to it