Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make logo link point to welcome page #11519

Merged
merged 1 commit into from
Nov 1, 2020

Conversation

mistercrunch
Copy link
Member

SUMMARY

New that we have a home page, let's point the logo to it

@codecov-io
Copy link

codecov-io commented Oct 31, 2020

Codecov Report

Merging #11519 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11519      +/-   ##
==========================================
+ Coverage   66.57%   66.63%   +0.05%     
==========================================
  Files         873      873              
  Lines       41777    41767      -10     
  Branches     3826     3826              
==========================================
+ Hits        27814    27832      +18     
+ Misses      13861    13833      -28     
  Partials      102      102              
Flag Coverage Δ
cypress 55.80% <ø> (+0.33%) ⬆️
javascript 62.64% <ø> (ø)
python 62.09% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/base.py 73.19% <ø> (+0.13%) ⬆️
.../src/dashboard/components/gridComponents/Chart.jsx 85.71% <0.00%> (+1.02%) ⬆️
...t-frontend/src/dashboard/actions/dashboardState.js 68.18% <0.00%> (+1.29%) ⬆️
...perset-frontend/src/messageToasts/actions/index.ts 95.83% <0.00%> (+8.33%) ⬆️
...et-frontend/src/messageToasts/components/Toast.tsx 100.00% <0.00%> (+8.33%) ⬆️
...rontend/src/visualizations/FilterBox/FilterBox.jsx 68.75% <0.00%> (+10.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3b6dbe...995fc2d. Read the comment docs.

@nytai
Copy link
Member

nytai commented Nov 1, 2020

Additionally, should we also make the home page route / and redirect /superset/welcome there to preserve old links? I'm not sure of the history here. I always thought the lack of any content on / a bit strange.

@mistercrunch
Copy link
Member Author

@nytai I think the reason is that it's a bit of a puzzle around how FAB does things and issues around python circular imports. I don't think it's super hard put requires a bit of thinking / refactoring.

@mistercrunch mistercrunch merged commit 854a461 into apache:master Nov 1, 2020
@mistercrunch mistercrunch deleted the home branch November 1, 2020 17:22
@rusackas
Copy link
Member

rusackas commented Nov 2, 2020

Adjusting the route was on our radar for follow-up, when the moon is right. I'd actually wondered if it could just be at /superset instead of /superset/welcome

The other quandry is if/when we want to add profile/role information to the homepage (perhaps as a sidebar, perhaps as a hero/header) to replace the feature of the user page you could previously get to by clicking the logo.

... or maybe that should all be shoved under the user/account menu in the top right somehow. ¯\_(ツ)_/¯

@ktmud
Copy link
Member

ktmud commented Nov 2, 2020

Should we plan adding user profile picture as well? Maybe use gravatar.com to get started?

auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants