Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify Apache Kylin datetime convert #11521

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

simplify Apache Kylin DateTime convert function

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Nov 2, 2020

Codecov Report

Merging #11521 into master will decrease coverage by 10.84%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #11521       +/-   ##
===========================================
- Coverage   66.54%   55.69%   -10.85%     
===========================================
  Files         873      411      -462     
  Lines       41767    14194    -27573     
  Branches     3826     3622      -204     
===========================================
- Hits        27792     7905    -19887     
+ Misses      13873     6121     -7752     
- Partials      102      168       +66     
Flag Coverage Δ
cypress 55.69% <ø> (+0.22%) ⬆️
javascript ?
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/components/Menu/LanguagePicker.tsx 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...uperset-frontend/src/utils/getClientErrorObject.ts 0.00% <0.00%> (-89.19%) ⬇️
...ntend/src/views/CRUD/annotation/AnnotationList.tsx 3.57% <0.00%> (-88.74%) ⬇️
...c/explore/components/controls/withVerification.jsx 9.09% <0.00%> (-87.88%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
...rc/dashboard/components/gridComponents/Divider.jsx 13.33% <0.00%> (-86.67%) ⬇️
... and 695 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 854a461...4394804. Read the comment docs.

@zhaoyongjie zhaoyongjie changed the title Chore: simplify Apache Kylin datetime convert chore: simplify Apache Kylin datetime convert Nov 2, 2020
@zhaoyongjie zhaoyongjie closed this Nov 2, 2020
@zhaoyongjie zhaoyongjie reopened this Nov 2, 2020
@zhaoyongjie
Copy link
Member Author

@villebro please review this PR, thanks.

@villebro villebro merged commit cd0198a into apache:master Nov 10, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@zhaoyongjie zhaoyongjie deleted the simplify_kylin_dttm_convert branch January 16, 2021 04:17
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants