Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove directory importexport #11531

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

betodealmeida
Copy link
Member

SUMMARY

This PR moves the ExportModelsCommand from superset/importexport/commands to superset/commands/ to better align with #9077.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

Verified unit tests

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida requested a review from hughhhh November 2, 2020 21:25
@codecov-io
Copy link

codecov-io commented Nov 2, 2020

Codecov Report

Merging #11531 into master will decrease coverage by 4.46%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11531      +/-   ##
==========================================
- Coverage   66.61%   62.15%   -4.47%     
==========================================
  Files         875      420     -455     
  Lines       42061    26194   -15867     
  Branches     3912        0    -3912     
==========================================
- Hits        28019    16280   -11739     
+ Misses      13940     9914    -4026     
+ Partials      102        0     -102     
Flag Coverage Δ
cypress ?
javascript ?
python 62.15% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/commands/export.py 96.96% <ø> (ø)
superset/charts/commands/export.py 94.28% <100.00%> (ø)
superset/dashboards/commands/export.py 93.93% <100.00%> (ø)
superset/databases/commands/export.py 94.28% <100.00%> (ø)
superset/datasets/commands/export.py 94.11% <100.00%> (ø)
superset/queries/saved_queries/commands/export.py 94.28% <100.00%> (ø)
superset/db_engines/hive.py 82.14% <0.00%> (-3.58%) ⬇️
...et-frontend/src/explore/reducers/exploreReducer.js
.../dashboard/util/logging/findNonTabChildChartIds.js
...ponents/Select/WindowedSelect/WindowedMenuList.tsx
... and 452 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 536346f...2ef65cf. Read the comment docs.

Copy link
Member

@hughhhh hughhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@betodealmeida betodealmeida force-pushed the remove_importexport_dir branch from 3b0b762 to 2ef65cf Compare November 3, 2020 23:41
@betodealmeida betodealmeida merged commit 1ebeffa into apache:master Nov 4, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants