Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace react-bootstrap MenuItems with Antd Menu #11555

Merged
merged 5 commits into from
Nov 4, 2020

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Nov 4, 2020

SUMMARY

Replaces MenuItems in SubMenu, PopoverDropdown and Button components.
The highlight colour in PopoverDropdown is slightly different (as on the screenshots), because the old one wasn't available in Superset theme.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@kgabryje
Copy link
Member Author

kgabryje commented Nov 4, 2020

@rusackas @junlincc Can you take a look?

@codecov-io
Copy link

codecov-io commented Nov 4, 2020

Codecov Report

Merging #11555 into master will decrease coverage by 5.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11555      +/-   ##
==========================================
- Coverage   66.62%   61.45%   -5.18%     
==========================================
  Files         875      420     -455     
  Lines       42035    26194   -15841     
  Branches     3909        0    -3909     
==========================================
- Hits        28006    16097   -11909     
+ Misses      13926    10097    -3829     
+ Partials      103        0     -103     
Flag Coverage Δ
cypress ?
javascript ?
python 61.45% <ø> (-0.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/db_engine_specs/hive.py 53.90% <0.00%> (-30.08%) ⬇️
superset/db_engine_specs/presto.py 69.76% <0.00%> (-12.53%) ⬇️
superset/db_engine_specs/mysql.py 79.59% <0.00%> (-12.25%) ⬇️
superset/examples/world_bank.py 97.10% <0.00%> (-2.90%) ⬇️
superset/examples/birth_names.py 96.51% <0.00%> (-2.33%) ⬇️
superset/views/database/mixins.py 80.70% <0.00%> (-1.76%) ⬇️
superset/models/core.py 87.60% <0.00%> (-1.66%) ⬇️
superset/views/core.py 73.77% <0.00%> (-0.49%) ⬇️
superset/connectors/sqla/models.py 90.36% <0.00%> (-0.27%) ⬇️
... and 452 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 937f9ca...06da968. Read the comment docs.

@mistercrunch mistercrunch merged commit 3e35ddd into apache:master Nov 4, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
)

* Remove MenuItem from SubMenu

* Fix tests

* Refactor PopoverDropdown

* Refactor Button

* Remove redundant Menu import
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants