chore: Enabled artifacts for failing tests

[adam-stasiak]

SUMMARY

Added uploading artifacts to failed pipelines to make PR validation easier. Now you can find screenshots it in artifacts.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[codecov-io]

Codecov Report

Merging #11584 into master will decrease coverage by 4.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11584      +/-   ##
==========================================
- Coverage   66.59%   62.31%   -4.29%     
==========================================
  Files         876      876              
  Lines       42146    42139       -7     
  Branches     3943     3943              
==========================================
- Hits        28066    26257    -1809     
- Misses      13977    15700    +1723     
- Partials      103      182      +79     

Flag	Coverage Δ
cypress	?
javascript	62.56% <ø> (ø)
python	62.15% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/SqlLab/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/dashboard/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/index.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/dashboard/index.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/setup/setupColors.js	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/chart/ChartContainer.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/setup/setupFormatters.js	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/reducers/index.js	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/setup/setupPluginsExtra.js	0.00% <0.00%> (-100.00%)	⬇️
... and 178 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 091432e...6f94656. Read the comment docs.

[ktmud]

Cool beans! Note that @rusackas is also working on enabling Cypress.io dashboard which also has screenshots for failed tests. But I guess it doesn't hurt to have them in both places.

[adam-stasiak]

I know but as I know (I did not see this in action yet) cypress dashboard access is granted for invited users. So only selected people would have a preview of failures. With this enabled on GitHub - anyone can see the result.

Edit: I double checked and possible that in OS project it can be visible for everyone. https://www.cypress.io/oss-plan/

[ktmud]

We do have an OSS plan and the report will be open to everyone.