-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (explore): handle null value in date filter #11655
fix (explore): handle null value in date filter #11655
Conversation
I think the convention is to style the PR title like |
Codecov Report
@@ Coverage Diff @@
## master #11655 +/- ##
==========================================
- Coverage 62.26% 55.43% -6.84%
==========================================
Files 873 406 -467
Lines 42306 14344 -27962
Branches 3971 3691 -280
==========================================
- Hits 26341 7951 -18390
+ Misses 15785 6230 -9555
+ Partials 180 163 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
(cherry picked from commit a9f9c4b)
(cherry picked from commit 9cba83b)
SUMMARY
when Date Filter got
null
in props, explore view page crash and throw JS error like:TEST PLAN
CI and manual test