-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Dropdown menu not closing on Dashboard view #11671
Conversation
I remember before the change the menu for charts would open on the left side of the trigger, now it opens on the right side. Can we make sure it always opens on the left side as the menu could be considered part of the chart and overlaying within the chart container makes sense. |
@ktmud Done |
Codecov Report
@@ Coverage Diff @@
## master #11671 +/- ##
==========================================
+ Coverage 62.36% 62.84% +0.48%
==========================================
Files 874 887 +13
Lines 42336 42931 +595
Branches 3972 3989 +17
==========================================
+ Hits 26402 26980 +578
- Misses 15754 15772 +18
+ Partials 180 179 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thanks, @kgabryje ! Could you fix the Cypress test, too? Then this one is good to go! |
6ba1d17
to
49ada5e
Compare
SUMMARY
Fixes Menus not closing automatically. It turned out that Antd Menu doesn't work that well with react-bootstrap's DropdownButton, so I replaced it with Antd's Dropdown. We should do the same for other mixes of Menu with DropdownButton soon, as the same issue might occur.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION