-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(saved query): handle null sql field #11679
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11679 +/- ##
==========================================
- Coverage 62.86% 60.25% -2.61%
==========================================
Files 889 843 -46
Lines 43054 41339 -1715
Branches 4016 3729 -287
==========================================
- Hits 27064 24909 -2155
- Misses 15811 16265 +454
+ Partials 179 165 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
f6d366c
to
c14d6c6
Compare
retriggering CI |
c14d6c6
to
c8c3616
Compare
SUMMARY
There's an error in the typing of SavedQueryObject,
sql
field can be null which causes the preview modal to error out.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
ADDITIONAL INFORMATION