Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "Select all" option in SelectControl on Explore view #11692

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

kgabryje
Copy link
Member

SUMMARY

On Explore view, "Select all" option on select controls did not work.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

ezgif com-gif-maker (1)

TEST PLAN

Go to Explore, select a Table chart, click Group by -> select all.

ADDITIONAL INFORMATION

CC: @graceguo-supercat @junlincc @rusackas

@kgabryje kgabryje changed the title fix: Select all option in SelectControl fix: "Select all" option in SelectControl on Explore view Nov 13, 2020
@codecov-io
Copy link

codecov-io commented Nov 13, 2020

Codecov Report

Merging #11692 (23ae7cc) into master (2f036e9) will decrease coverage by 6.85%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11692      +/-   ##
==========================================
- Coverage   62.85%   56.00%   -6.86%     
==========================================
  Files         889      408     -481     
  Lines       43053    14437   -28616     
  Branches     4015     3716     -299     
==========================================
- Hits        27063     8085   -18978     
+ Misses      15812     6352    -9460     
+ Partials      178        0     -178     
Flag Coverage Δ
cypress 56.00% <0.00%> (?)
javascript ?
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/explore/components/controls/SelectControl.jsx 87.61% <0.00%> (+0.82%) ⬆️
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
...rc/dashboard/components/gridComponents/Divider.jsx 13.33% <0.00%> (-86.67%) ⬇️
...set-frontend/src/views/CRUD/welcome/EmptyState.tsx 5.71% <0.00%> (-82.10%) ⬇️
...et-frontend/src/components/ListView/ActionsBar.tsx 11.11% <0.00%> (-81.20%) ⬇️
...et-frontend/src/components/Menu/LanguagePicker.tsx 0.00% <0.00%> (-80.00%) ⬇️
... and 798 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f036e9...23ae7cc. Read the comment docs.

@kgabryje kgabryje closed this Nov 13, 2020
@kgabryje kgabryje reopened this Nov 13, 2020
@junlincc junlincc requested a review from ktmud November 13, 2020 15:38
Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graceguo-supercat graceguo-supercat merged commit 8a39f27 into apache:master Nov 17, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants