Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding __init__.py in superset.commands.importers #11740

Merged
merged 3 commits into from
Nov 18, 2020

Conversation

craig-rueda
Copy link
Member

SUMMARY

Adds missing init.py to superset.commands.importers, which causes app to fail on init

@codecov-io
Copy link

codecov-io commented Nov 18, 2020

Codecov Report

Merging #11740 (f25a774) into master (7ae8cd0) will decrease coverage by 3.60%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11740      +/-   ##
==========================================
- Coverage   66.74%   63.13%   -3.61%     
==========================================
  Files         897      897              
  Lines       43463    43455       -8     
  Branches     4015     4015              
==========================================
- Hits        29009    27435    -1574     
- Misses      14349    15842    +1493     
- Partials      105      178      +73     
Flag Coverage Δ
cypress ?
javascript 62.82% <ø> (ø)
python 63.31% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset/databases/commands/importers/v1/__init__.py 96.92% <100.00%> (ø)
...uperset/datasets/commands/importers/v1/__init__.py 92.75% <100.00%> (ø)
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupFormatters.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
... and 158 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ae8cd0...f25a774. Read the comment docs.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Craig!

@betodealmeida betodealmeida merged commit 8bdf943 into apache:master Nov 18, 2020
craig-rueda added a commit to preset-io/superset that referenced this pull request Nov 18, 2020
* Adding __init__.py in superset.commands.importers

* Linting

* Linting again...

(cherry picked from commit 8bdf943)
@craig-rueda craig-rueda deleted the craig/importer-package branch November 18, 2020 22:16
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
* Adding __init__.py in superset.commands.importers

* Linting

* Linting again...
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants