Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add user info to sqllab via bootstrap data #11760

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Nov 20, 2020

SUMMARY

Allow user information to be surfaced in sqllab app. This PR will make the data available in JS and in #11755 i'll be hooking it up the getInitialState

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Nov 20, 2020

Codecov Report

Merging #11760 (14b2a71) into master (cdd01f4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11760   +/-   ##
=======================================
  Coverage   63.14%   63.14%           
=======================================
  Files         897      897           
  Lines       43460    43461    +1     
  Branches     4188     4188           
=======================================
+ Hits        27443    27444    +1     
  Misses      15837    15837           
  Partials      180      180           
Flag Coverage Δ
javascript 62.83% <ø> (ø)
python 63.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/core.py 74.20% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdd01f4...14b2a71. Read the comment docs.

@hughhhh hughhhh merged commit 1ef3a02 into master Nov 20, 2020
@hughhhh hughhhh deleted the add-userinfo-sqllab branch November 20, 2020 02:32
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants