Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update docs around email reports #11783

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

eschutho
Copy link
Member

SUMMARY

I noticed while debugging with this flag that you have to run superset init in order for the menu/pages to appear. Some people have apparently gotten bit by something similar in the past, and it takes a while to figure out if you don't know what you're looking for, so I added it to the docs.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho changed the title update docs around email reports docs: update docs around email reports Nov 23, 2020
@codecov-io
Copy link

codecov-io commented Nov 23, 2020

Codecov Report

Merging #11783 (b91a668) into master (cdd01f4) will decrease coverage by 8.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11783      +/-   ##
==========================================
- Coverage   63.14%   55.12%   -8.03%     
==========================================
  Files         897      411     -486     
  Lines       43460    14521   -28939     
  Branches     4188     3725     -463     
==========================================
- Hits        27443     8004   -19439     
+ Misses      15837     6517    -9320     
+ Partials      180        0     -180     
Flag Coverage Δ
cypress 55.12% <ø> (?)
javascript ?
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
...rc/dashboard/components/gridComponents/Divider.jsx 13.33% <0.00%> (-86.67%) ⬇️
...ontend/src/dashboard/util/getDashboardFilterKey.ts 14.28% <0.00%> (-85.72%) ⬇️
...set-frontend/src/views/CRUD/welcome/EmptyState.tsx 5.71% <0.00%> (-82.10%) ⬇️
...et-frontend/src/components/ListView/ActionsBar.tsx 11.11% <0.00%> (-81.20%) ⬇️
...et-frontend/src/components/Menu/LanguagePicker.tsx 0.00% <0.00%> (-80.00%) ⬇️
... and 809 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdd01f4...b91a668. Read the comment docs.

@willbarrett willbarrett merged commit 302357f into apache:master Nov 24, 2020
@willbarrett willbarrett deleted the elizabeth/update-flag-docs branch November 24, 2020 19:43
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants