Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add certification info to table selector #11785

Merged

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Nov 23, 2020

SUMMARY

The current table selector only gets table names from the database engine itself, and leaves out any additional metadata a user may have provided to a physical dataset. This merges the tables list returned from the database with any extra metadata from the datasets so we can display certification status in table selectors throughout the product

AFTER SCREENSHOTS

Screen Shot 2020-11-23 at 3 05 50 PM
Screen Shot 2020-11-23 at 2 25 44 PM

TEST PLAN

  • View tables in the selector with certification status and see the icon + tooltip
  • View tables in the selector without certification and see no icon
  • See the certification icon after a table is selected

ADDITIONAL INFORMATION

  • Has associated issue: Certification of Data Entities #10591
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

to: @ktmud @graceguo-supercat @bkyryliuk @john-bodley

@codecov-io
Copy link

codecov-io commented Nov 23, 2020

Codecov Report

Merging #11785 (a9891d0) into master (db73869) will decrease coverage by 3.84%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11785      +/-   ##
==========================================
- Coverage   67.20%   63.35%   -3.85%     
==========================================
  Files         903      905       +2     
  Lines       43719    43867     +148     
  Branches     4199     4205       +6     
==========================================
- Hits        29380    27791    -1589     
- Misses      14235    15896    +1661     
- Partials      104      180      +76     
Flag Coverage Δ
cypress ?
javascript 62.86% <71.42%> (+0.02%) ⬆️
python 63.64% <42.85%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontend/src/components/CertifiedIconWithTooltip.tsx 60.00% <0.00%> (-6.67%) ⬇️
superset/connectors/sqla/models.py 90.76% <33.33%> (-0.47%) ⬇️
superset-frontend/src/components/TableSelector.tsx 84.74% <83.33%> (+2.44%) ⬆️
superset/views/core.py 74.22% <100.00%> (+0.02%) ⬆️
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
... and 175 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db73869...a9891d0. Read the comment docs.

@etr2460 etr2460 force-pushed the erik-ritter--table-certification-selector branch 3 times, most recently from a533ead to 233f226 Compare November 24, 2020 03:59
Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm with one small comment.

return json.loads(self.extra)
except (TypeError, json.JSONDecodeError):
return {}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wdyt of making this be a @property?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@etr2460 etr2460 force-pushed the erik-ritter--table-certification-selector branch from 233f226 to a9891d0 Compare November 24, 2020 18:18
Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etr2460 etr2460 merged commit c0224aa into apache:master Nov 24, 2020
Copy link
Member

@willbarrett willbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post-hoc LGTM

john-bodley added a commit to john-bodley/superset that referenced this pull request Jul 28, 2022
@mistercrunch mistercrunch added the 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants