Add Russian translation #1182
Merged
Add Russian translation #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So it looks like we have something marked as a lazy string that shouldn't that is displayed on the menus |
xrmx
reviewed
Sep 26, 2016
| @@ -1809,39 +1809,39 @@ msgstr "Добро пожаловать!" | |||
| msgid "Test Connection" | |||
There was a problem hiding this comment.
If you revert all these changes below does it still work?
There was a problem hiding this comment.
I've commented out all the changes below, it still doesn't. Now I've made another changes, hope it will work.
There was a problem hiding this comment.
I have no idea what's exactly wrong. I've just put Russian translation in msgstr section. But unit-tests are failed when the version 3.4 and higher. Well I'll try to find out.
|
Looks like the PR is off a very old commit. Can you rebase or star over from master? I'd do it easily but want to make sure you get "credited" for your commit/PR |
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.