Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable keyboard shortcut for running empty query in SQL Lab #11877

Merged
merged 1 commit into from
Dec 4, 2020
Merged

fix: disable keyboard shortcut for running empty query in SQL Lab #11877

merged 1 commit into from
Dec 4, 2020

Conversation

kkucharc
Copy link
Contributor

@kkucharc kkucharc commented Dec 1, 2020

SUMMARY

Using CTRL + R or CTRL + Enter when there is empty input for queries in SQL Lab is disabled and doesn't perform any action.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before it was returning error:

Database Error
local variable 'result_set' referenced before assignment

After:
hotkey is not doing anything.

TEST PLAN

  1. Go to SQL Lab
  2. Delete everything in the text area (including SELECT ...)
  3. Press CTRL+R or CTRL+Enter
    No error

ADDITIONAL INFORMATION

Fixes: #11587

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@kkucharc kkucharc requested a review from rusackas December 3, 2020 18:44
rusackas
rusackas approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit 98dc657 into apache:master Dec 4, 2020
@m-ajay m-ajay mentioned this pull request Jul 4, 2023
Open
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@betodealmeida betodealmeida Awaiting requested review from betodealmeida

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL Lab: CTRL+R and CTRL+ENTER bypass disabled RUN button
3 participants
@kkucharc @rusackas @mistercrunch