Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(releasing): support changelog csv export #11893

Merged
merged 2 commits into from
Dec 5, 2020

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Dec 2, 2020

SUMMARY

Created a new option for the release script "changelog" to export the changelog to CSV files

Usage:
python changelog.py --current_version 0.38.0 --previous_version 0.37.2 changelog --csv changelog_0_38_0.csv

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
dpgaspar Daniel Vaz Gaspar
@codecov-io
Copy link

codecov-io commented Dec 2, 2020

Codecov Report

Merging #11893 (00a73d8) into master (0728878) will decrease coverage by 12.71%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #11893       +/-   ##
===========================================
- Coverage   67.65%   54.93%   -12.72%     
===========================================
  Files         927      421      -506     
  Lines       45009    14812    -30197     
  Branches     4306     3822      -484     
===========================================
- Hits        30450     8137    -22313     
+ Misses      14455     6675     -7780     
+ Partials      104        0      -104     
Flag Coverage Δ
cypress 54.93% <ø> (-0.06%) ⬇️
javascript ?
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
...rc/dashboard/components/gridComponents/Divider.jsx 13.33% <0.00%> (-86.67%) ⬇️
...ontend/src/dashboard/util/getDashboardFilterKey.ts 14.28% <0.00%> (-85.72%) ⬇️
...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx 14.70% <0.00%> (-82.97%) ⬇️
...set-frontend/src/views/CRUD/welcome/EmptyState.tsx 5.71% <0.00%> (-82.10%) ⬇️
...et-frontend/src/SqlLab/components/TableElement.jsx 4.70% <0.00%> (-81.35%) ⬇️
... and 776 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0728878...00a73d8. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 At some point we should probably do a cleanup pass to add typing and such, as this is becoming a more critical piece of the release process.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
dpgaspar Daniel Vaz Gaspar
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 4, 2020
@dpgaspar
Copy link
Member Author

dpgaspar commented Dec 4, 2020

Looks good 👍 At some point we should probably do a cleanup pass to add typing and such, as this is becoming a more critical piece of the release process.

True, updated it, it's completely type annotated and passed pylint to it also

@dpgaspar dpgaspar merged commit f98ae01 into apache:master Dec 5, 2020
@dpgaspar dpgaspar deleted the feat/change-log-csv branch December 5, 2020 08:55
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants