fix: adjust width for non multi select inputs #11911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschutho
force-pushed
the
elizabeth/non-multi-select-width
branch
from
757c871 to
f6bd186
Compare
nytai
approved these changes
Dec 3, 2020
Codecov Report
@@ Coverage Diff @@
## master #11911 +/- ##
==========================================
- Coverage 66.04% 63.78% -2.27%
==========================================
Files 927 462 -465
Lines 45016 28418 -16598
Branches 4309 0 -4309
==========================================
- Hits 29730 18125 -11605
+ Misses 15151 10293 -4858
+ Partials 135 0 -135
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
etr2460
reviewed
Dec 3, 2020
Comment on lines
261
to
266
| const styles = { | ||
| background: 'none', | ||
| border: 'none', | ||
| outline: 'none', | ||
| padding: 0, | ||
| }; |
There was a problem hiding this comment.
perhaps this object should be defined as a const as INPUT_TAG_STYLES?
Then you could get rid of the function entirely and just do:
inputStyle={isMultiWithValue ? { ...INPUT_TAG_STYLES, width: '100%' } : INPUT_TAG_STYLES}on line 335
There was a problem hiding this comment.
SGTM! I made one slight change, and named it INPUT_TAG_BASE_STYLES b/c they don't apply as is to all the input tags.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
slight formatting fix for selects when used as filters on the CRUD pages for example that was introduced in #11732
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TEST PLAN
visual comparisons
ADDITIONAL INFORMATION