refactor: Upgrade Redux #11967
Merged
refactor: Upgrade Redux #11967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11967 +/- ##
==========================================
+ Coverage 63.75% 63.81% +0.05%
==========================================
Files 941 941
Lines 45654 45860 +206
Branches 4389 4459 +70
==========================================
+ Hits 29106 29264 +158
- Misses 16371 16418 +47
- Partials 177 178 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
suddjian
commented
Dec 9, 2020
| @@ -86,7 +86,7 @@ export function fetchFaveStar(sliceId: string) { | |||
|
|
|||
| export const SAVE_FAVE_STAR = 'SAVE_FAVE_STAR'; | |||
| export function saveFaveStar(sliceId: string, isStarred: boolean) { | |||
| return function (dispatch: Dispatch<ReturnType<typeof addDangerToast>>) { | |||
There was a problem hiding this comment.
The latest version of Redux has a better-typed dispatch function, so the extra typing here doesn't compile anymore, for good reason.
graceguo-supercat
approved these changes
Dec 9, 2020
6 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
At @graceguo-supercat's suggestion, I've extracted the Redux upgrade done by @pkdotson and myself in #11814. This gets us ✨ hooks ✨ for redux state!
Many tests had to be changed because Enzyme can't propagate context correctly through shallow-rendered components. Side note: can't wait to start using react-testing-library.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION