Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change paddings on ListView and SubMenu #11975

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Dec 9, 2020

SUMMARY

Decreases paddings around filter row on DashboardList, ChartList and other views with SubMenu and ListView.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: see linked issue
After:
image

TEST PLAN

Manually verify that views with SubMenu and ListView still look good

ADDITIONAL INFORMATION

@mistercrunch @junlincc Can you take a look?

@codecov-io
Copy link

codecov-io commented Dec 9, 2020

Codecov Report

Merging #11975 (dde79d1) into master (cc44a2c) will decrease coverage by 11.86%.
The diff coverage is 45.45%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #11975       +/-   ##
===========================================
- Coverage   66.26%   54.40%   -11.87%     
===========================================
  Files         941      431      -510     
  Lines       45715    15201    -30514     
  Branches     4395     3885      -510     
===========================================
- Hits        30293     8270    -22023     
+ Misses      15287     6931     -8356     
+ Partials      135        0      -135     
Flag Coverage Δ
cypress 54.40% <45.45%> (+10.59%) ⬆️
javascript ?
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/components/ListView/Filters/index.tsx 62.50% <ø> (-24.46%) ⬇️
...rset-frontend/src/components/ListView/ListView.tsx 76.66% <33.33%> (-19.26%) ⬇️
...rontend/src/components/ListView/CardSortSelect.tsx 78.94% <100.00%> (-16.89%) ⬇️
superset-frontend/src/components/Menu/SubMenu.tsx 93.10% <100.00%> (-6.90%) ⬇️
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
...rc/dashboard/components/gridComponents/Divider.jsx 13.33% <0.00%> (-86.67%) ⬇️
... and 827 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc44a2c...dde79d1. Read the comment docs.

@mistercrunch
Copy link
Member

mistercrunch commented Dec 9, 2020

closes #11965

@kgabryje protip: if you write closes https://github.com/apache/incubator-superset/issues/11965 in your PR top comment it'll link to the issue and auto-close it when the PR gets merged

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit a4b06d2 into apache:master Dec 9, 2020
@kgabryje
Copy link
Member Author

closes #11965

@kgabryje protip: if you write closes https://github.com/apache/incubator-superset/issues/11965 in your PR top comment it'll link to the issue and auto-close it when the PR gets merged

Thanks, good to know!

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cosmetic] too much vertical padding on the filter row
4 participants