Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add invisible layer on loading chart #11994

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Dec 10, 2020

SUMMARY

When chart is loading, we show a spinner icon on top of chart, but it won't block user interact with chart. This will cause some issue for filter box: In large dashboard with many filter box, user applies a filter, other filter may update accordingly. If user interact with filter box while it is waiting for query results, it will make dashboard stuck in a wired state or show errors.

This PR is to add an invisible layer on top of chart. When chart is loading, user can not interact with the chart. There is no visible UI change for loading chart, but user can not change filter dropdown:

Screen Shot 2020-12-09 at 11 34 02 PM

TEST PLAN

  • CI
  • Manual test:
  1. open dashboard with multiple filter boxes: both dashboard and filter box should aligned as before.
  2. apply one filter,
  3. when filter box is loading, you can not select dropdown anymore.

cc @zuzana-vej @etr2460 @ktmud

@etr2460
Copy link
Member

etr2460 commented Dec 10, 2020

Could you attach screenshots/a test plan around this too? Making the chart position: relative seems like it might cause some bugs. wanna make sure everything's tested with scrolling, tabs, etc

@graceguo-supercat
Copy link
Author

The screenshot in the description is the UI after this PR.

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit, thanks for the fix!

@graceguo-supercat
Copy link
Author

graceguo-supercat commented Dec 10, 2020

this will be invisible layer look like if i add some color for it (color will not committed in this PR):
Screen Shot 2020-12-10 at 10 28 26 AM

@graceguo-supercat graceguo-supercat merged commit 0fdf026 into apache:master Dec 11, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants