feat: add invisible layer on loading chart #11994
Merged
+22
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When chart is loading, we show a spinner icon on top of chart, but it won't block user interact with chart. This will cause some issue for filter box: In large dashboard with many filter box, user applies a filter, other filter may update accordingly. If user interact with filter box while it is waiting for query results, it will make dashboard stuck in a wired state or show errors.
This PR is to add an invisible layer on top of chart. When chart is loading, user can not interact with the chart. There is no visible UI change for loading chart, but user can not change filter dropdown:
TEST PLAN
cc @zuzana-vej @etr2460 @ktmud