Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove generic type #12003

Merged
merged 5 commits into from
Dec 11, 2020
Merged

Conversation

betodealmeida
Copy link
Member

SUMMARY

We were passing a generics type that is actually not needed.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

N/A

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida
Copy link
Member Author

cc: @eschutho

@codecov-io
Copy link

codecov-io commented Dec 10, 2020

Codecov Report

Merging #12003 (5a8933a) into master (916f7e9) will decrease coverage by 3.91%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12003      +/-   ##
==========================================
- Coverage   67.88%   63.97%   -3.92%     
==========================================
  Files         948      948              
  Lines       46177    46167      -10     
  Branches     4405     4405              
==========================================
- Hits        31348    29536    -1812     
- Misses      14722    16453    +1731     
- Partials      107      178      +71     
Flag Coverage Δ
cypress ?
javascript 62.96% <50.00%> (ø)
python 64.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/views/CRUD/types.ts 100.00% <ø> (ø)
superset-frontend/src/views/CRUD/hooks.ts 57.23% <33.33%> (-10.90%) ⬇️
...rset-frontend/src/components/ImportModal/index.tsx 74.24% <100.00%> (ø)
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/dashboard/containers/Dashboard.jsx 0.00% <0.00%> (-100.00%) ⬇️
... and 171 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 916f7e9...5a8933a. Read the comment docs.

@betodealmeida betodealmeida merged commit 2769de3 into apache:master Dec 11, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants