-
Notifications
You must be signed in to change notification settings - Fork 15.5k
feat: load examples from config instead of code #12026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12026 +/- ##
==========================================
+ Coverage 63.72% 63.78% +0.05%
==========================================
Files 956 474 -482
Lines 46941 29270 -17671
Branches 4589 0 -4589
==========================================
- Hits 29915 18669 -11246
+ Misses 16842 10601 -6241
+ Partials 184 0 -184
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
f886f32
to
e3d5a5d
Compare
a57a1fc
to
2f542ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice improvement !
d270a25
to
a115395
Compare
SUMMARY
Currently the examples that come with Superset are all generated by Python scripts, making modifying the existing examples or creating new ones unnecessarily complicated.
With the new export/import functionality from SIP-54 we can store the examples in the repo as YAML files instead of code. This way the examples can be easily modified, and new examples can be created inside Superset, exported and added to the repo.
In this PR I moved the "Unicode test" example to YAML files. Doing so required a few modifications, namely, adding a
data
attribute to the dataset config pointing to a URL where the data can be download as a CSV. This is similar to howload_examples
currently work, with the difference that we don't know the column types a priori, so they need to be inferred from the dataset metadata.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
I loaded the examples, and verified that the unicode test is imported and set up correctly.
ADDITIONAL INFORMATION