Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable browser autocomplete for DeleteModal #12043

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

nytai
Copy link
Member

@nytai nytai commented Dec 14, 2020

SUMMARY

See title and linked issue

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screen Shot 2020-12-14 at 1 12 41 PM

After:
Screen Shot 2020-12-14 at 1 12 13 PM

TEST PLAN

  • Ensure no browser autocomplete dropdown appears for the delete modal input

ADDITIONAL INFORMATION

@codecov-io
Copy link

codecov-io commented Dec 14, 2020

Codecov Report

Merging #12043 (a814759) into master (d5b16bc) will decrease coverage by 3.84%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12043      +/-   ##
==========================================
- Coverage   67.71%   63.86%   -3.85%     
==========================================
  Files         952      952              
  Lines       46686    46689       +3     
  Branches     4577     4578       +1     
==========================================
- Hits        31615    29820    -1795     
- Misses      14958    16685    +1727     
- Partials      113      184      +71     
Flag Coverage Δ
cypress ?
javascript 62.69% <ø> (+0.04%) ⬆️
python 64.58% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/DeleteModal.tsx 100.00% <ø> (ø)
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/dashboard/containers/Dashboard.jsx 0.00% <0.00%> (-100.00%) ⬇️
...t-frontend/src/dashboard/containers/SliceAdder.jsx 0.00% <0.00%> (-100.00%) ⬇️
...-frontend/src/visualizations/presets/MainPreset.js 0.00% <0.00%> (-100.00%) ⬇️
... and 173 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5b16bc...a814759. Read the comment docs.

@nytai nytai merged commit fda3a2f into apache:master Dec 14, 2020
@nytai nytai deleted the tai/disable-delete-autocomplete branch December 14, 2020 22:11
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[list view]user can delete items by typing 'delete'(lower case) in stead of DELETE
4 participants