Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: small fixes to the new import/export #12064

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

betodealmeida
Copy link
Member

SUMMARY

This PR includes a few small fixes to the import/export feature:

  1. Micro optimizations: some JSON fields may be empty strings, so we only serialize/deserialize them if they have an actual document.
  2. Fixes: I was checking for the wrong exception when dumping JSON to a string (copy-and-paste mistakes, sigh).
  3. Deserialize more fields: some of the fields that had a JSON payload were not being deserialized when exporting to YAML.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

Unit tests green

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@hughhhh hughhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@betodealmeida betodealmeida merged commit e0079bb into apache:master Dec 15, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants