feat: initial custom error messages for SQL Lab

[betodealmeida]

SUMMARY

This PR adds the exception SupersetGenericDBErrorException, so we can start showing custom errors in SQL Lab. I still need to replace calls to json_response_error with throwing the exception in many parts of the view, but it already works for some errors (see screenshots).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[codecov-io]

Codecov Report

Merging #12080 (0ea9c5b) into master (48fb8c0) will decrease coverage by 4.23%.
The diff coverage is 43.90%.

@@            Coverage Diff             @@
##           master   #12080      +/-   ##
==========================================
- Coverage   67.56%   63.32%   -4.24%     
==========================================
  Files         959      971      +12     
  Lines       47161    47959     +798     
  Branches     4613     4735     +122     
==========================================
- Hits        31864    30371    -1493     
- Misses      15185    17402    +2217     
- Partials      112      186      +74     

Flag	Coverage Δ
cypress	?
javascript	62.05% <0.00%> (-0.63%)	⬇️
python	64.11% <75.00%> (-0.20%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...erset-frontend/src/SqlLab/components/ResultSet.tsx	66.82% <ø> (-0.16%)	⬇️
.../components/ErrorMessage/ParameterErrorMessage.tsx	0.00% <0.00%> (ø)
superset-frontend/src/setup/setupErrorMessages.ts	0.00% <0.00%> (-61.54%)	⬇️
superset/views/core.py	75.37% <44.44%> (-0.08%)	⬇️
superset/exceptions.py	96.61% <92.85%> (+4.61%)	⬆️
superset/views/base.py	75.21% <100.00%> (+0.84%)	⬆️
superset-frontend/src/SqlLab/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/dashboard/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/setup/setupColors.js	0.00% <0.00%> (-100.00%)	⬇️
... and 229 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48fb8c0...0ea9c5b. Read the comment docs.

[etr2460]

thanks for taking on this work! One question, how will this work for async queries? Or is that out of scope for now?

[betodealmeida]

thanks for taking on this work! One question, how will this work for async queries? Or is that out of scope for now?

Yeah! My plan is to split the work into 3 parts:

1. This PR
2. Other sync errors
3. Async errors

I haven't looked at the async part yet, from I'm assuming we'll have to serialize the exception?

[etr2460]

yeah, i think we'll need to serialize it into the error_message column in the query table, then do some checks on the other side to see if we can parse it as a dict or not

[etr2460]

a few comments

[etr2460]

one nit, otherwise lgtm