Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the Flaky test for FilterBox re-introduced by #12114 #12124

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Dec 18, 2020

SUMMARY

Try to fix the Flaky test for FilterBox re-introduced by #12114 . It seems the test is still failing after merging.

Let's see if this fixes it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

Codecov Report

Merging #12124 (066bfb5) into master (49ec13c) will decrease coverage by 2.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12124      +/-   ##
==========================================
- Coverage   65.86%   63.45%   -2.42%     
==========================================
  Files         972      481     -491     
  Lines       48051    29669   -18382     
  Branches     4716        0    -4716     
==========================================
- Hits        31650    18825   -12825     
+ Misses      16259    10844    -5415     
+ Partials      142        0     -142     
Flag Coverage Δ
cypress ?
javascript ?
python 63.45% <ø> (-0.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/views/database/views.py 62.69% <0.00%> (-24.88%) ⬇️
superset/db_engine_specs/mysql.py 79.59% <0.00%> (-12.25%) ⬇️
superset/db_engine_specs/sqlite.py 65.62% <0.00%> (-9.38%) ⬇️
superset/db_engine_specs/presto.py 73.81% <0.00%> (-8.59%) ⬇️
superset/databases/commands/create.py 83.67% <0.00%> (-8.17%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/db_engine_specs/base.py 80.73% <0.00%> (-6.87%) ⬇️
superset/sql_validators/base.py 93.33% <0.00%> (-6.67%) ⬇️
superset/views/database/forms.py 83.33% <0.00%> (-5.56%) ⬇️
... and 510 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49ec13c...066bfb5. Read the comment docs.

@ktmud
Copy link
Member Author

ktmud commented Dec 18, 2020

Looks like it worked!

@ktmud ktmud merged commit d543ca8 into apache:master Dec 18, 2020
@ktmud ktmud deleted the fix-cypress-test branch December 18, 2020 18:31
villebro pushed a commit to preset-io/superset that referenced this pull request Jan 7, 2021
villebro pushed a commit to preset-io/superset that referenced this pull request Jan 7, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants