Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: database alpha permissions #12136

Merged
merged 3 commits into from
Dec 21, 2020

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Dec 18, 2020

SUMMARY

Fix database for alpha user's should be readonly

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar marked this pull request as ready for review December 18, 2020 23:08
@codecov-io
Copy link

codecov-io commented Dec 18, 2020

Codecov Report

Merging #12136 (86e3b69) into master (b5dd0f3) will decrease coverage by 4.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12136      +/-   ##
==========================================
- Coverage   67.15%   63.04%   -4.11%     
==========================================
  Files         994      994              
  Lines       49033    49019      -14     
  Branches     4977     4977              
==========================================
- Hits        32929    30905    -2024     
- Misses      15982    17914    +1932     
- Partials      122      200      +78     
Flag Coverage Δ
cypress ?
javascript 61.23% <ø> (ø)
python 64.21% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/security/manager.py 91.01% <100.00%> (+0.29%) ⬆️
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/dashboard/containers/Dashboard.jsx 0.00% <0.00%> (-100.00%) ⬇️
...t-frontend/src/dashboard/containers/SliceAdder.jsx 0.00% <0.00%> (-100.00%) ⬇️
...t-frontend/src/explore/reducers/getInitialState.js 0.00% <0.00%> (-100.00%) ⬇️
... and 184 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5dd0f3...86e3b69. Read the comment docs.

@dpgaspar dpgaspar requested a review from willbarrett December 18, 2020 23:14
@dpgaspar dpgaspar merged commit 2f0add3 into apache:master Dec 21, 2020
@dpgaspar dpgaspar deleted the fix/database-alpha-perms branch December 21, 2020 19:18
henryyeh pushed a commit to preset-io/superset that referenced this pull request Dec 21, 2020
* fix: database alpha permissions

* add test

(cherry picked from commit 2f0add3)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants