Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database): adjust column sizing for list view #12146

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

nytai
Copy link
Member

@nytai nytai commented Dec 19, 2020

SUMMARY

  • adjust column widths for database list view to allow full table to show at 1280px viewport width (MBP 13in)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen Shot 2020-12-18 at 10 00 18 PM

After:

Screen Shot 2020-12-18 at 10 00 38 PM

TEST PLAN

👀

  • adjust browser viewport to be 1280px wide
  • table should render all columns in view

ADDITIONAL INFORMATION

@codecov-io
Copy link

codecov-io commented Dec 19, 2020

Codecov Report

Merging #12146 (a02fbc6) into master (865beae) will decrease coverage by 2.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12146      +/-   ##
==========================================
- Coverage   65.82%   63.33%   -2.49%     
==========================================
  Files         988      988              
  Lines       48702    48690      -12     
  Branches     4907     4907              
==========================================
- Hits        32056    30840    -1216     
- Misses      16501    17656    +1155     
- Partials      145      194      +49     
Flag Coverage Δ
cypress ?
javascript 61.98% <ø> (+0.01%) ⬆️
python 64.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/src/views/CRUD/data/database/DatabaseList.tsx 79.20% <ø> (ø)
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/dashboard/containers/Dashboard.jsx 0.00% <0.00%> (-100.00%) ⬇️
...t-frontend/src/dashboard/containers/SliceAdder.jsx 0.00% <0.00%> (-100.00%) ⬇️
...-frontend/src/visualizations/presets/MainPreset.js 0.00% <0.00%> (-100.00%) ⬇️
...tend/src/dashboard/containers/DashboardBuilder.jsx 0.00% <0.00%> (-100.00%) ⬇️
... and 135 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 865beae...a02fbc6. Read the comment docs.

@nytai nytai marked this pull request as ready for review December 19, 2020 07:21
@nytai nytai merged commit ba952ba into apache:master Dec 21, 2020
@nytai nytai deleted the tai/adjust-db-column-widths branch December 21, 2020 05:26
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Crud view] Data-->Databases page: Edit buttons invisible on database editor on crud view
4 participants