fix: Filter Bar scrolling #12156
Merged
fix: Filter Bar scrolling #12156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusackas
approved these changes
Dec 22, 2020
There was a problem hiding this comment.
Code LGTM, pending QA by @junlincc or @adam-stasiak or anyone who wants to pull/test the branch :D
|
Tested - OK! |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes bug in Filter Bar. When there was many filters added, Filter Bar scrolling did not work properly, as presented below.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
Set feature flag
DASHBOARD_NATIVE_FILTERSto true.Go to Dashboards, choose one and create a bunch of Filters. Try to scroll Filter Bar up and down.
ADDITIONAL INFORMATION
cc @rusackas @villebro @junlincc