Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename variable for clarity #12159

Merged
merged 1 commit into from
Dec 21, 2020
Merged

chore: rename variable for clarity #12159

merged 1 commit into from
Dec 21, 2020

Conversation

betodealmeida
Copy link
Member

SUMMARY

I introduced a variable called undefined in #12113, I'm renaming it to undefined_parameters (Python) and undefinedParameter (Javascript) to avoid confusion.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

N/A

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

ktmud
ktmud approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this!

@ktmud
Copy link
Member

ktmud commented Dec 21, 2020

Any reason to have different pluralities between python and js?

@betodealmeida
Copy link
Member Author

Any reason to have different pluralities between python and js?

In Python we're returning all undefined parameters. In JS we loop over them and generate a custom message for each one, so it's a single parameter.

@betodealmeida betodealmeida merged commit ce1abc9 into apache:master Dec 21, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktmud ktmud ktmud approved these changes

@hughhhh hughhhh Awaiting requested review from hughhhh

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@betodealmeida @ktmud @mistercrunch @junlincc