feat: add new dashboard with video game sales #12162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12162 +/- ##
==========================================
- Coverage 66.91% 63.06% -3.85%
==========================================
Files 972 994 +22
Lines 48036 49045 +1009
Branches 4743 4979 +236
==========================================
- Hits 32141 30930 -1211
- Misses 15775 17915 +2140
- Partials 120 200 +80
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
betodealmeida
force-pushed
the
video_game_sales
branch
3 times, most recently
from
fe91c37
to
2ccf00e
Compare
betodealmeida
force-pushed
the
video_game_sales
branch
from
2ccf00e
to
8d5b536
Compare
dpgaspar
approved these changes
Dec 22, 2020
| @@ -81,6 +81,15 @@ def update_id_refs(config: Dict[str, Any], chart_ids: Dict[str, int]) -> Dict[st | |||
| for old_id, value in metadata["expanded_slices"].items() | |||
| } | |||
|
|
|||
| if "default_filters" in metadata: | |||
There was a problem hiding this comment.
nit: This switch type logic on update_id_refs if it grows (or even now) is asking for a small refactor IMO
6 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adding a new dashboard by @srinify, showing sales of video games.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Ran
superset load_examples.ADDITIONAL INFORMATION