-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(explore): save chart not working #12178
Conversation
0213dc2
to
d748464
Compare
d748464
to
d851472
Compare
Codecov Report
@@ Coverage Diff @@
## master #12178 +/- ##
==========================================
- Coverage 66.75% 63.05% -3.71%
==========================================
Files 994 994
Lines 49068 49059 -9
Branches 4979 4979
==========================================
- Hits 32756 30933 -1823
- Misses 16184 17926 +1742
- Partials 128 200 +72
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
SUMMARY
Saving a chart is currently broken due to the save action returning an incorrect object, likely caused by #11997.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION