Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): save chart not working #12178

Merged
merged 2 commits into from
Dec 22, 2020

Conversation

villebro
Copy link
Member

@villebro villebro commented Dec 22, 2020

SUMMARY

Saving a chart is currently broken due to the save action returning an incorrect object, likely caused by #11997.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

@villebro villebro changed the title fix(explore): save to dashboard not working fix(explore): save chart not working Dec 22, 2020
@villebro villebro force-pushed the villebro/save-to-dashboard branch from 0213dc2 to d748464 Compare December 22, 2020 16:09
@villebro villebro force-pushed the villebro/save-to-dashboard branch from d748464 to d851472 Compare December 22, 2020 16:11
@codecov-io
Copy link

codecov-io commented Dec 22, 2020

Codecov Report

Merging #12178 (2941493) into master (942e321) will decrease coverage by 3.70%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12178      +/-   ##
==========================================
- Coverage   66.75%   63.05%   -3.71%     
==========================================
  Files         994      994              
  Lines       49068    49059       -9     
  Branches     4979     4979              
==========================================
- Hits        32756    30933    -1823     
- Misses      16184    17926    +1742     
- Partials      128      200      +72     
Flag Coverage Δ
cypress ?
javascript 61.23% <50.00%> (ø)
python 64.23% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-frontend/src/explore/actions/saveModalActions.js 61.29% <0.00%> (ø)
...rset-frontend/src/explore/components/SaveModal.tsx 85.88% <100.00%> (ø)
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/dashboard/containers/Dashboard.jsx 0.00% <0.00%> (-100.00%) ⬇️
...t-frontend/src/dashboard/containers/SliceAdder.jsx 0.00% <0.00%> (-100.00%) ⬇️
...t-frontend/src/explore/reducers/getInitialState.js 0.00% <0.00%> (-100.00%) ⬇️
... and 175 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 942e321...2941493. Read the comment docs.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@villebro villebro closed this Dec 22, 2020
@villebro villebro reopened this Dec 22, 2020
@villebro villebro merged commit 41fac6b into apache:master Dec 22, 2020
@villebro villebro deleted the villebro/save-to-dashboard branch December 22, 2020 21:18
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save overwrite chart and add to dashboard error
4 participants