Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(report): add/edit modal improvements #12183

Merged

Conversation

lilykuang
Copy link
Member

@lilykuang lilykuang commented Dec 22, 2020

SUMMARY

  • changed sql field from textarea to TextAreaControl with sql highlight
  • added helper text for cron schedule field
  • added helper text for notification method

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2020-12-22 at 10 29 53 AM

TEST PLAN

  • ui unit test

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Dec 22, 2020

Codecov Report

Merging #12183 (978d666) into master (a52031a) will decrease coverage by 3.53%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12183      +/-   ##
==========================================
- Coverage   66.61%   63.08%   -3.54%     
==========================================
  Files         994      994              
  Lines       49079    49074       -5     
  Branches     4982     4983       +1     
==========================================
- Hits        32695    30956    -1739     
- Misses      16254    17918    +1664     
- Partials      130      200      +70     
Flag Coverage Δ
cypress ?
javascript 61.26% <90.90%> (+0.02%) ⬆️
python 64.25% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 46.88% <85.71%> (+0.78%) ⬆️
...CRUD/alert/components/AlertReportCronScheduler.tsx 88.46% <100.00%> (+1.50%) ⬆️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/dashboard/containers/Dashboard.jsx 0.00% <0.00%> (-100.00%) ⬇️
...t-frontend/src/dashboard/containers/SliceAdder.jsx 0.00% <0.00%> (-100.00%) ⬇️
...t-frontend/src/explore/reducers/getInitialState.js 0.00% <0.00%> (-100.00%) ⬇️
... and 175 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a52031a...01175ed. Read the comment docs.

@lilykuang lilykuang force-pushed the lily/alert-report-modal-improvement branch from 978d666 to 01175ed Compare December 22, 2020 21:16
Copy link
Member

@nytai nytai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. I'm wondering if we really need to crontab.guru link, it seems to me that users who are unfamiliar with cron syntax should use the picker and users who want to write cron strings can do so via the input box.

@lilykuang lilykuang merged commit ff0fe43 into apache:master Jan 4, 2021
@lilykuang lilykuang deleted the lily/alert-report-modal-improvement branch January 4, 2021 17:16
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants