fix(reports): make name unique between alerts and reports #12196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgaspar
added
risk:db-migration
Codecov Report
@@ Coverage Diff @@
## master #12196 +/- ##
==========================================
- Coverage 63.06% 62.84% -0.23%
==========================================
Files 994 995 +1
Lines 49075 49106 +31
Branches 4984 4983 -1
==========================================
- Hits 30950 30861 -89
- Misses 17925 18045 +120
Partials 200 200
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dpgaspar
commented
Dec 23, 2020
|
|
||
| else: | ||
| with op.batch_alter_table( | ||
| "report_schedule", copy_from=report_schedule |
There was a problem hiding this comment.
This was required to remove UNIQUE (name) that is not an actual constraint from SQLite
nytai
approved these changes
Dec 24, 2020
villebro
approved these changes
Dec 24, 2020
Comment on lines
+95
to
+100
| with op.batch_alter_table( | ||
| "report_schedule", copy_from=report_schedule | ||
| ) as batch_op: | ||
| batch_op.create_unique_constraint( | ||
| "uq_report_schedule_name_type", ["name", "type"] | ||
| ) |
There was a problem hiding this comment.
This took a loong while for me to wrap my head around 😆 A small comment here could be really helpful for the next person trying to understand what's going on.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Uniqueness was being imposed on Alerts/Report names, preventing user's from creating an Alert name "X" and a Report with the same name "X". This allows it while still enforcing name uniqueness on Alerts and Reports separately
Also guarantees that a database reference is not sent when creating a report
ADDITIONAL INFORMATION