-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tests errors and warnings - iteration 1 (#12212) #12213
fix: tests errors and warnings - iteration 1 (#12212) #12213
Conversation
thanks for the PRs @michael-s-molina! is there a test plan for them? |
We just need to run the tests and verify that the errors and warnings are decreasing. Most of the changes are in spec files and the ones that change a component are covered by a test. |
Codecov Report
@@ Coverage Diff @@
## master #12213 +/- ##
==========================================
- Coverage 66.20% 64.19% -2.01%
==========================================
Files 996 485 -511
Lines 49174 29830 -19344
Branches 4993 0 -4993
==========================================
- Hits 32554 19149 -13405
+ Misses 16476 10681 -5795
+ Partials 144 0 -144
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Hi, @michael-s-molina , thanks for the contribution! This looks great. I know this is probably too much to ask, but could you comment on each change on which errors/warnings they are supposed to solve if you still remember? PR review comments are fine. |
@ktmud I updated the PR description to include fixed errors and warnings. I'll do the same with the other PRs. |
Thanks so much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a couple of small nits.
e4da213
to
6cf6acc
Compare
@ktmud Accepted suggested changes. I did a force push to preserve commit history. |
SUMMARY
Remove tests errors and warnings to improve results readability.
The following errors and warnings have been removed:
#12212
@rusackas @junlincc @villebro
ADDITIONAL INFORMATION