-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(home): add ErrorBoundary to Charts section #12239
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12239 +/- ##
===========================================
- Coverage 66.20% 51.38% -14.82%
===========================================
Files 996 466 -530
Lines 49174 16768 -32406
Branches 4993 4304 -689
===========================================
- Hits 32554 8617 -23937
+ Misses 16476 8151 -8325
+ Partials 144 0 -144
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
BTW, thanks for your first contribution, @maxamante ! Welcome aboard! |
SUMMARY
Hello, I am interested in contributing to Superset. Found issue #12149 and thought it would be a good way to learn the system. If you would like me to create a separate issue for this, I can do that.
#12149 wants to add an ErrorBoundary to specific components. I picked the ChartTable on the Welcome component, which I believe is the same as the 2nd item under the 5. Home Page mentioned in the issue. I replaced the root
React.Fragment (<>)
with anErrorBoundary
. I found the router logic and some other components using theErrorBoundary
this way.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
I wasn't sure how to proceed with testing or if it was desired. I didn't find any tests that tested the ErrorBoundary itself or any components that import it. The superset-ui repo has some tests I can take cues from. I'm more than happy to add tests, unless the ErrorBoundary is enough. Advice would be great!
ADDITIONAL INFORMATION