Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reports): don't log user errors and state change has errors #12277

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jan 5, 2021

SUMMARY

Don't log misconfigure alerts (with bad SQL or unsupported results) has errors on the worker. Also logs information about log pruning

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar closed this Jan 5, 2021
@dpgaspar dpgaspar reopened this Jan 5, 2021
@codecov-io
Copy link

codecov-io commented Jan 5, 2021

Codecov Report

Merging #12277 (3014e8c) into master (d4a854e) will decrease coverage by 4.17%.
The diff coverage is 8.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12277      +/-   ##
==========================================
- Coverage   67.17%   63.00%   -4.18%     
==========================================
  Files        1002     1002              
  Lines       49231    49232       +1     
  Branches     5000     5000              
==========================================
- Hits        33073    31019    -2054     
- Misses      16035    18013    +1978     
- Partials      123      200      +77     
Flag Coverage Δ
cypress ?
javascript 61.25% <ø> (ø)
python 64.14% <8.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/reports/commands/log_prune.py 0.00% <0.00%> (ø)
superset/reports/dao.py 78.50% <0.00%> (-0.75%) ⬇️
superset/tasks/scheduler.py 0.00% <0.00%> (ø)
superset/reports/commands/exceptions.py 98.59% <100.00%> (+0.04%) ⬆️
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
... and 196 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4a854e...3014e8c. Read the comment docs.

@dpgaspar dpgaspar merged commit 0171a6b into apache:master Jan 6, 2021
@dpgaspar dpgaspar deleted the fix/report-logging-err branch January 6, 2021 08:57
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants